Closed insightlane closed 3 months ago
get_afltables_stats() mostly provides Local.start.time as an integer in 24-hour time (e.g. 1500 for 3:00PM).
However, in many instances in 2020 (and some sporadic instances elsewhere) it is recorded in 12-hour time (e.g. 300 for 3:00PM).
Most of these examples are from 2020, with a quick spot check also finding some in 1900, 1901, 1907 and 1912.
Brief description of the problem
afltables_data %>% distinct(Season, Local.start.time) %>% arrange(Local.start.time) # A tibble: 867 x 2 Season Local.start.time <dbl> <int> 1 2020 105 2 2020 145 3 2020 235 4 1900 300 5 1907 300 6 1901 300 7 1912 300 8 2020 305 9 2020 335 10 2020 435 # ... with 857 more rows afltables_data %>% distinct(Season, Local.start.time) %>% filter(Season == 2020) %>% arrange(Local.start.time) # A tibble: 36 x 2 Season Local.start.time <dbl> <int> 1 2020 105 2 2020 145 3 2020 235 4 2020 305 5 2020 335 6 2020 435 7 2020 510 8 2020 540 9 2020 605 10 2020 610 # ... with 26 more rows afltables_data %>% distinct(Season, Local.start.time) %>% filter(Season < 2020) %>% arrange(Local.start.time) # A tibble: 831 x 2 Season Local.start.time <dbl> <int> 1 1900 300 2 1907 300 3 1901 300 4 1912 300 5 1938 1030 6 1920 1045 7 1899 1100 8 1998 1140 9 1987 1210 10 2014 1210
https://github.com/jimmyday12/fitzRoy/pull/223
get_afltables_stats() mostly provides Local.start.time as an integer in 24-hour time (e.g. 1500 for 3:00PM).
However, in many instances in 2020 (and some sporadic instances elsewhere) it is recorded in 12-hour time (e.g. 300 for 3:00PM).
Most of these examples are from 2020, with a quick spot check also finding some in 1900, 1901, 1907 and 1912.
Brief description of the problem