search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

Prepare for rvest 1.0.0 #137

Closed hadley closed 3 years ago

hadley commented 3 years ago

Which removes the pluck() function.

I could get the tests working but if you can create a simple reprex for the get_footywire_betting_odds()/calculate_round_number() number test failure, I'm happy to take a look.

You might also generally want to take a look at your tests because I'm seeing a lot of warnings. I fixed a few problems, but it really needs a thorough review.

jimmyday12 commented 3 years ago

Thanks so much @hadley - I will take a look at this over the weekend