search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

fitzRoy::fetch_fixture_footywire() errors out on an older version of R #146

Closed kaushiklakshman closed 3 years ago

kaushiklakshman commented 3 years ago

Hi fitzRoy crew,

Thanks for all the work on the package development.

Recently noticed something while making a fresh install of the package on a new computer. What seemed to work on R version 4.0.4 errored out on R version 3.6.3. I've attached a reprex with the same code run on both environments on the same computer to show you the difference. Any clue what might be causing it? Thanks!

This is 4.0.4 that works fine 

remotes::install_github("jimmyday12/fitzRoy", force = TRUE)
#> Downloading GitHub repo jimmyday12/fitzRoy@HEAD
#>
#>          checking for file 'C:\Users\liuc\AppData\Local\Temp\Rtmpeq5JD0\remotesd80781d293d\jimmyday12-fitzRoy-c0da22e/DESCRIPTION' ...  v  checking for file 'C:\Users\liuc\AppData\Local\Temp\Rtmpeq5JD0\remotesd80781d293d\jimmyday12-fitzRoy-c0da22e/DESCRIPTION' (367ms)
#>       -  preparing 'fitzRoy': (1.2s)
#>    checking DESCRIPTION meta-information ...     checking DESCRIPTION meta-information ...   v  checking DESCRIPTION meta-information
#>       -  checking for LF line-endings in source and make files and shell scripts
#>       -  checking for empty or unneeded directories
#>       -  building 'fitzRoy_1.0.0.tar.gz'
#>
#>
library(fitzRoy)
sessionInfo()
#> R version 4.0.4 (2021-02-15)
#> Platform: x86_64-w64-mingw32/x64 (64-bit)
#> Running under: Windows 10 x64 (build 19041)
#>
#> Matrix products: default
#>
#> locale:
#> [1] LC_COLLATE=English_Australia.1252  LC_CTYPE=English_Australia.1252
#> [3] LC_MONETARY=English_Australia.1252 LC_NUMERIC=C
#> [5] LC_TIME=English_Australia.1252
#>
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base
#>
#> other attached packages:
#> [1] fitzRoy_1.0.0
#>
#> loaded via a namespace (and not attached):
#>  [1] knitr_1.31        magrittr_2.0.1    R6_2.5.0          rlang_0.4.10
#>  [5] fansi_0.4.2       stringr_1.4.0     styler_1.3.2      highr_0.8
#>  [9] tools_4.0.4       pkgbuild_1.2.0    xfun_0.22         utf8_1.2.1
#> [13] cli_2.3.1         withr_2.4.1       htmltools_0.5.1.1 ellipsis_0.3.1
#> [17] remotes_2.2.0     rprojroot_2.0.2   assertthat_0.2.1  yaml_2.2.1
#> [21] digest_0.6.27     tibble_3.1.0      lifecycle_1.0.0   crayon_1.4.1
#> [25] processx_3.4.5    callr_3.5.1       purrr_0.3.4       ps_1.6.0
#> [29] vctrs_0.3.6       fs_1.5.0          curl_4.3          glue_1.4.2
#> [33] evaluate_0.14     rmarkdown_2.7     reprex_1.0.0      stringi_1.5.3
#> [37] compiler_4.0.4    pillar_1.5.1      prettyunits_1.1.1 backports_1.2.1
#> [41] pkgconfig_2.0.3
fitzRoy::fetch_fixture_footywire()
#> # A tibble: 198 x 7
#>    Date                Season Season.Game Round Home.Team   Away.Team   Venue
#>    <dttm>               <dbl>       <int> <dbl> <chr>       <chr>       <chr>
#>  1 2021-03-18 19:25:00   2021           1     1 Richmond    Carlton     M.C.G.
#>  2 2021-03-19 19:50:00   2021           2     1 Collingwood Footscray   M.C.G.
#>  3 2021-03-20 13:45:00   2021           3     1 Melbourne   Fremantle   M.C.G.
#>  4 2021-03-20 16:05:00   2021           4     1 Adelaide    Geelong     Adelaid~
#>  5 2021-03-20 18:45:00   2021           5     1 Brisbane L~ Sydney      Gabba
#>  6 2021-03-20 19:25:00   2021           6     1 Essendon    Hawthorn    Docklan~
#>  7 2021-03-21 13:10:00   2021           7     1 North Melb~ Port Adela~ Docklan~
#>  8 2021-03-21 15:10:00   2021           8     1 West Coast  Gold Coast  Perth S~
#>  9 2021-03-21 15:20:00   2021           9     1 GWS         St Kilda    Sydney ~
#> 10 2021-03-25 19:20:00   2021          10     2 Carlton     Collingwood M.C.G.
#> # ... with 188 more rows

And this is 3.6.3 with the error 

remotes::install_github("jimmyday12/fitzRoy", force = TRUE)
#> Downloading GitHub repo jimmyday12/fitzRoy@HEAD
#>
#>          checking for file 'C:\Users\liuc\AppData\Local\Temp\Rtmp8mLe6S\remotes5f827ac2f8a\jimmyday12-fitzRoy-c0da22e/DESCRIPTION' ...     checking for file 'C:\Users\liuc\AppData\Local\Temp\Rtmp8mLe6S\remotes5f827ac2f8a\jimmyday12-fitzRoy-c0da22e/DESCRIPTION' ...   v  checking for file 'C:\Users\liuc\AppData\Local\Temp\Rtmp8mLe6S\remotes5f827ac2f8a\jimmyday12-fitzRoy-c0da22e/DESCRIPTION' (360ms)
#>       -  preparing 'fitzRoy': (1.2s)
#>    checking DESCRIPTION meta-information ...     checking DESCRIPTION meta-information ...   v  checking DESCRIPTION meta-information
#>       -  checking for LF line-endings in source and make files and shell scripts
#>       -  checking for empty or unneeded directories
#>       -  looking to see if a 'data/datalist' file should be added
#>       -  building 'fitzRoy_1.0.0.tar.gz'
#>
#>
#> Installing package into 'C:/Users/liuc/Documents/R/win-library/3.6'
#> (as 'lib' is unspecified)
library(fitzRoy)
sessionInfo()
#> R version 3.6.3 (2020-02-29)
#> Platform: x86_64-w64-mingw32/x64 (64-bit)
#> Running under: Windows 10 x64 (build 19041)
#>
#> Matrix products: default
#>
#> locale:
#> [1] LC_COLLATE=English_Australia.1252  LC_CTYPE=English_Australia.1252
#> [3] LC_MONETARY=English_Australia.1252 LC_NUMERIC=C
#> [5] LC_TIME=English_Australia.1252
#>
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base
#>
#> other attached packages:
#> [1] fitzRoy_1.0.0
#>
#> loaded via a namespace (and not attached):
#>  [1] knitr_1.31        magrittr_2.0.1    R6_2.5.0          rlang_0.4.10
#>  [5] fansi_0.4.2       stringr_1.4.0     styler_1.3.2      highr_0.8
#>  [9] tools_3.6.3       pkgbuild_1.2.0    xfun_0.22         utf8_1.2.1
#> [13] cli_2.3.1         withr_2.4.1       htmltools_0.5.1.1 ellipsis_0.3.1
#> [17] remotes_2.2.0     rprojroot_2.0.2   assertthat_0.2.1  yaml_2.2.1
#> [21] digest_0.6.27     tibble_3.1.0      lifecycle_1.0.0   crayon_1.4.1
#> [25] processx_3.4.5    callr_3.5.1       purrr_0.3.4       ps_1.6.0
#> [29] vctrs_0.3.6       fs_1.5.0          curl_4.3          glue_1.4.2
#> [33] evaluate_0.14     rmarkdown_2.7     reprex_1.0.0      stringi_1.5.3
#> [37] compiler_3.6.3    pillar_1.5.1      prettyunits_1.1.1 backports_1.2.1
#> [41] pkgconfig_2.0.3
fitzRoy::fetch_fixture_footywire()
#> Error: Problem with `mutate()` input `Venue`.
#> x must be a character vector, not a `factor` object.
#> i Input `Venue` is `replace_venues(.data$Venue)`.
#> i The error occurred in group 1: Season.Game = 1.
jimmyday12 commented 3 years ago

Ta mate - had a quick look and found the issue. It's a one liner fix so will fix it up later this arvo (hopefully before the first match!)

kaushiklakshman commented 3 years ago

Great, thanks mate