search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

Coaches Vote Functions #159

Closed jlholden26 closed 3 years ago

jlholden26 commented 3 years ago

Function to scrape coaches vote data and ascertain probabilities as discussed on twitter 31 August. Never done this sort of thing before so let me know if I've missed anything.

jimmyday12 commented 3 years ago

Nice! Thanks mate. I'll review this for you and provide a bit of feedback soon

jlholden26 commented 3 years ago

I think I addressed everything - let me know what you reckon.

jimmyday12 commented 3 years ago

Thanks @jlholden26 - made a couple changes locally and merged so should be all in there! May tidy a couple things up before we push this version to CRAN but it should be working on the dev version. Thanks again :)

jimmyday12 commented 3 years ago

Hey @jlholden26 - do you mind sending me your details to add to the DESCRIPTION file as a contributor (forgot to mention that in the PR). Alternatively you can just update the DESCRIPTION file yourself in another PR.

There is a section called Authors@R; and you just add an entry to the list.

      person(given = "Name",
             family = "Surname",
             role = "ctb",
             email = "email@email.com"))
jlholden26 commented 3 years ago

@jimmyday12 here are the details:

person(given = "Jacob", family = "Holden", role = "ctb", email = "jlholden26@gmail.com"))