jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 28 forks source link

fetch_player_stats_afltables test fails due to missing Brownlow votes #198

Closed bairdj closed 1 year ago

bairdj commented 1 year ago

The fetch_player_stats_afltables works for various inputs checks that there are no NA Brownlow.Votes values. This test uses the current season as its test data (if it has commenced), but if the Brownlow count hasn't yet been held, then all values will be NA. This was introduced in 1d45fbd. Previously this separately checked the previous year to ensure Brownlow votes were present.

Failure (test-fetch-player-stats.R:34): fetch_player_stats_afltables works for various inputs
sum(is.na(dat$Brownlow.Votes)) (`actual`) not equal to 0 (`expected`).

  `actual`: 828
`expected`:   0