fetch_player_details_afl currently returning no data for all seasons

jimmyday12 / fitzRoy

A set of functions to easily access AFL data

https://jimmyday12.github.io/fitzRoy

Other

125 stars 27 forks source link

fetch_player_details_afl currently returning no data for all seasons #206

Closed peteowen1 closed 11 months ago

peteowen1 commented 11 months ago

fetch_player_details_afl currently is returning no data for all seasons.

This is because the fetch_teams_afl function is currently having an issue where it filters out all rows with an NA in any column - but new metadata has been added to these tables which often has multiple NA values.

A fix has been suggested in the pull request below

https://github.com/jimmyday12/fitzRoy/pull/205

jimmyday12 commented 11 months ago

Linked PR closes this

databatch commented 4 months ago

I am encountering the same issue

> fitzRoy::fetch_player_details_afl(2020,
+                                   team = NULL,
+                                   comp = "AFLM",
+                                   official_teams = FALSE)
# A tibble: 0 × 1
# ℹ 1 variable: data_accessed <date>