search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
129 stars 27 forks source link

Can't fetch 2024 AFLTables stats #238

Open Beer-Jan opened 1 month ago

Beer-Jan commented 1 month ago

Hi, I've got a problem where the fetch_player_stats_afltables function is throwing up an error when I try to fetch data from 2024. I have tried fetch_player_stats(source = "afltables"), same result. This code:

library(fitzRoy)

fetch_player_stats_afltables(2024)

Gives the error

ℹ Looking for data from 2024-01-01 to 2024-07-29
✔ fetching cached data from <github.com> ... done
ℹ New data found for 9 matches
✔ Downloading data ... done
✔ Processing XMLS ... done                                                                                                               
Error in `dplyr::bind_rows()`:
! Can't combine `..1$ID` <character> and `..2$ID` <double>.
liam-crow commented 1 month ago

same error #fitzRoy_1.4.0.9000

peteowen1 commented 1 month ago

Try installing the latest version

install.packages("devtools") devtools::install_github("jimmyday12/fitzRoy")

It seems to work fine for me. I'll make sure to increment the development version number going forward so it's obvious which version is being used.

jimmyday12 commented 1 month ago

I'm going to package up the development version to push out on CRAN given we've made a bunch of changes recently. Will get that sorted in the next day or so

peteowen1 commented 1 month ago

have run devtools::check() on pushes and seems to pass all tests Let me know if you need me to add anything more to NEWS or any documentation

jimmyday12 commented 1 month ago

have run devtools::check() on pushes and seems to pass all tests Let me know if you need me to add anything more to NEWS or any documentation

All good. Got a few things I run through each time I submit to CRAN, currently tracking them here https://github.com/jimmyday12/fitzRoy/issues/239