jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
132 stars 27 forks source link

afltables 2019 data error #70

Closed jt026 closed 5 years ago

jt026 commented 5 years ago

Please briefly describe your problem and what output you expect.

Please include a minimal reproducible example (AKA a reprex). If you've never heard of a reprex before, start by reading https://www.tidyverse.org/help/#reprex.


Brief description of the problem error when trying to get 2019 data from afltables, works upto this season


# insert reprex here
fitzRoy::get_afltables_stats()
R version 3.5.2 (2018-12-20)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

Matrix products: default

locale:
[1] LC_COLLATE=English_Australia.1252  LC_CTYPE=English_Australia.1252    LC_MONETARY=English_Australia.1252
[4] LC_NUMERIC=C                       LC_TIME=English_Australia.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.0       rstudioapi_0.9.0 xml2_1.2.0       magrittr_1.5     hms_0.4.2        tidyselect_0.2.5
 [7] rvest_0.3.2      R6_2.4.0         rlang_0.3.1      stringr_1.4.0    httr_1.4.0       dplyr_0.8.0.1   
[13] tools_3.5.2      fitzRoy_0.1.11   selectr_0.4-1    yaml_2.2.0       assertthat_0.2.0 tibble_2.0.1    
[19] crayon_1.3.4     purrr_0.3.1      readr_1.3.1      tidyr_0.8.3      curl_3.3         glue_1.3.1      
[25] stringi_1.3.1    compiler_3.5.2   pillar_1.3.1     lubridate_1.7.4  pkgconfig_2.0.2 
jimmyday12 commented 5 years ago

Hi @jt026 I'm finally reviewing all the bugs reported over the last few months. Can you expand on what you expect here?

If I run fitzRoy::get_afltables_stats() with v0.1.12 it returns data from 1897 through to todays date (2019). Is this what you get?

jimmyday12 commented 5 years ago

closing for now