search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
132 stars 27 forks source link

Some 2019 finals round numbers are incorrect #84

Closed cfranklin11 closed 5 years ago

cfranklin11 commented 5 years ago

The round numbers for the last couple of finals rounds from the get_fixture function have been one higher than the actual round numbers due to the matchless week before finals. Running the following snippet will show that the first round of finals is correct with a Round of 24, but then skips to 26 for the following round.

tail(get_fixture(2019), 10)

The expected behaviour is for the round numbers to increment by one for each round, and the cause of this bug seems to be due to how round lags are reflected in the final round number calculations (i.e. the lag in a given round isn't propagated to later rounds).

I've opened a PR (#83) that should solve the issue.

cfranklin11 commented 5 years ago

The PR mentioned above was merged