search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
130 stars 27 forks source link

Add replace_venues function #91

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

Resolves #15

Different data sources use different naming conventions for venues, which requires mapping to make them consistent for joins. This change maps all known venue names to the corresponding name in AFL Tables. We use AFL Tables, because it is the most comprehensive data source and changes venue names less frequently than others.

jimmyday12 commented 4 years ago

Thanks @cfranklin11. I'm just in the middle of our first submission to CRAN (currently pending review) so I'll just hold off merging until that process finishes. Then I'll bump to a development version and merge this in.

jimmyday12 commented 4 years ago

@cfranklin11 OK - all good to get this merged in. Just noticed some conflicts that might need fixing. Make sure you also add a new bullet point in NEWS.md under 0.2.0.9000

jimmyday12 commented 4 years ago

@cfranklin11 See my other comment - good to get this merged in but some conflicts exist now. If you can fix them up I'll get it merged in :) Don't forget the bulletpoint in news.md

cfranklin11 commented 4 years ago

There seems to be an issue with caching apt packages in Travis CI that causes errors when installing dependencies. The last commit seems to fix it, but let me know if you find a better alternative.

cfranklin11 commented 4 years ago

@jimmyday12 I updated replace_venues to cover a recent name change on Footywire (I guess GWS changed the name of their stadium?). Due to the Travis CI fix in the last commit, I think it makes sense to merge this, then I can resolve any conflicts on #92, or I can make the Travis CI fix its own PR if you prefer.