search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
130 stars 27 forks source link

Some round numbers are incorrect for footywire data sources #93

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

I came across a few issues with round numbers recently:

  1. For get_footywire_betting_data the match on 2018-04-25 is in the wrong round due to the filter matching on date-time and betting data only having dates.

  2. Requesting multiple seasons for get_footywire_betting_data results in incorrect round numbers if the request includes 2014, because it started on week 11, whereas the other valid seasons all started on week 12. This makes non-2014 seasons start on round 2 instead of 1.

  3. A lot of round numbers are wrong in general largely due to all Sunday matches being off by one (e.g. Sunday matches in round 10 are actually labelled as being in round 11). Given that this worked before, I think it's due to lubridate changing how it calculates weekday numbers.