created function to return ladder

jimmyday12 / fitzRoy

A set of functions to easily access AFL data

https://jimmyday12.github.io/fitzRoy

Other

129 stars 27 forks source link

created function to return ladder #94

Closed JaseZiv closed 4 years ago

JaseZiv commented 4 years ago

Addressing issue #85

jimmyday12 commented 4 years ago

@JaseZiv - so I've made a commit (8fe62d2e04ee24b7f03f266765be3cca85061b43) that fixes the womens-stats error on Travis. If you merge master into your PR and resubmit it should be fine.

Also, just to note, to get tests to run on your local machine properly you have to do the following code since we are using skip_on_cran() in our tests.

Sys.setenv(NOT_CRAN = "true")
devtools::check()

Related to this issue that should be fixed soon in devtools

JaseZiv commented 4 years ago

@jimmyday12 Great stuff. Thanks for the heads up. Hope the function is of help.