search

jimmyday12 / fitzRoy

A set of functions to easily access AFL data
https://jimmyday12.github.io/fitzRoy
Other
130 stars 27 forks source link

Fix round number for Wednesday matches #96

Closed cfranklin11 closed 4 years ago

cfranklin11 commented 4 years ago

Resolves #95

As with other recent bugs for footywire round number calculations, I'm a bit confused as to what changed regarding how weeks and weekdays are counted to cause this, but something moved Wednesdays from the beginning to the end of the round week by default.

Changing the between filter to use Sunday and Tuesday as the limits makes the default round week Wednesday to Tuesday as intended.

jimmyday12 commented 4 years ago

Looks like there might be a new issue with AFLW data that is causing all tests to fail at the moment :( I might have to refactor that part of the code before merging this in

jimmyday12 commented 4 years ago

Ok made a commit (8fe62d2e04ee24b7f03f266765be3cca85061b43) that fixes the womens-stats error on Travis. If you merge master into your PR and resubmit it should be fine.

Also, just to note, to get tests to run on your local machine you have to do the following code since we are using skip_on_cran() in our tests. 

Sys.setenv(NOT_CRAN = "true")
devtools::check()

Related to this issue that should be fixed soon in devtools

cfranklin11 commented 4 years ago

Ok, rebased and pushed, and it looks like it's good to merge