jimmyeao / Elite-Dangerous-Addon-Launcher-V2

lightweight C# app to manage the launching (and closing!) of Elite Dangerous helper apps and websites
https://github.com/jimmyeao/Elite-Dangerous-Addon-Launcher-V2
MIT License
6 stars 0 forks source link

Crash on Install #23

Closed slider609 closed 3 months ago

slider609 commented 3 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Download and extract .zip file to Desktop
  2. Run Setup.exe
  3. See error

Expected behavior Program to install

Desktop (please complete the following information):

install.log:

The following properties have been set: Property: [AdminUser] = true {boolean} Property: [InstallMode] = HomeSite {string} Property: [NTProductType] = 1 {int} Property: [ProcessorArchitecture] = AMD64 {string} Property: [VersionNT] = 10.0.0 {version} Running checks for package '.NET Desktop Runtime 7.0.5 (x64)', phase BuildList Checking conditions before installer checks for command 'net7desktopruntime_x64\windowsdesktop-runtime-7.0.5-win-x64.exe' Result of running operator 'ValueEqualTo' on property 'ProcessorArchitecture' and value 'Intel': false Result of running operator 'ValueEqualTo' on property 'ProcessorArchitecture' and value 'Arm': false Result of checking conditions before installer checks for command 'net7desktopruntime_x64\windowsdesktop-runtime-7.0.5-win-x64.exe' is: No action Running external check with command 'C:\Users[USER]\AppData\Local\Temp\VSD63DE.tmp\net7desktopruntime_x64\NetCoreCheck.exe' and parameters 'Microsoft.WindowsDesktop.App 7.0.5' Process exited with code 0 Setting value '0 {int}' for property 'NetCoreCheck' The following properties have been set for package '.NET Desktop Runtime 7.0.5 (x64)': Property: [NetCoreCheck] = 0 {int} Running checks for command 'net7desktopruntime_x64\windowsdesktop-runtime-7.0.5-win-x64.exe' Result of running operator 'ValueEqualTo' on property 'ProcessorArchitecture' and value 'Intel': false Result of running operator 'ValueEqualTo' on property 'ProcessorArchitecture' and value 'Arm': false Result of running operator 'VersionLessThan' on property 'VersionNT' and value '6.1.0': false Result of running operator 'ValueEqualTo' on property 'NetCoreCheck' and value '0': true Result of checks for command 'net7desktopruntime_x64\windowsdesktop-runtime-7.0.5-win-x64.exe' is 'Bypass' '.NET Desktop Runtime 7.0.5 (x64)' RunCheck result: No Install Needed Launching Application. URLDownloadToCacheFile failed with HRESULT '-2146697210' Error: An error occurred trying to download 'https://thfhaappstore.blob.core.windows.net/edlaunch/Elite%20Dangerous%20Addon%20Launcer%20V2.application'.

github-actions[bot] commented 3 months ago

COngratulations on raising your first issue, we appreciate all feedback!

jimmyeao commented 3 months ago

Can you check this registry setting please to make sure you haven't turned off the caching of SSL pages?

[HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings] "DisableCachingOfSSLPages"=dword:00000000

Also make sure if you have any adblockers (pihole etc) it's not blocking https://*.blob.core.windows.net/

jimmyeao commented 3 months ago

Also re-uploaded the latest release - I notice there was a typo: 'https://thfhaappstore.blob.core.windows.net/edlaunch/Elite%20Dangerous%20Addon%20**Launcer**%20V2.application'. Launcher was spelled as "launcer"

slider609 commented 3 months ago

Also re-uploaded the latest release - I notice there was a typo: 'https://thfhaappstore.blob.core.windows.net/edlaunch/Elite%20Dangerous%20Addon%20**Launcer**%20V2.application'. Launcher was spelled as "launcer"

Can't download the latest version, virus detected by browsers.

slider609 commented 3 months ago

Can you check this registry setting please to make sure you haven't turned off the caching of SSL pages?

[HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings] "DisableCachingOfSSLPages"=dword:00000000

Also make sure if you have any adblockers (pihole etc) it's not blocking https://*.blob.core.windows.net/

Not blocking and registry key was good.

jimmyeao commented 3 months ago

There is no virus, you can scan it with Windows Defender to check - likely flagged because it's not downloaded much smartscreen in windows always flags non-signed files it doesn't see much. Malware Bytes and MaxSecure incorrectly flag it, but all others are ok :(https://www.virustotal.com/gui/file/a0b6695e853cf3a587c56dc8c7d09a119f53a13908da654a4f1688d06e864464/detection) Here you can see from the behaviour tab what files are created etc if you want extra reassurance.

jimmyeao commented 3 months ago

Have updated some of the libraries (Material Design Themes) and re-uploaded

jimmyeao commented 3 months ago

New Virus Total Report https://www.virustotal.com/gui/file/ab8f5e73f06e40cff46ef011f3f974dd0402a689f7b5170f4d1db7471e341d95/detection

slider609 commented 3 months ago

Downloaded and install. Thank you.