Change domains to binary_sensor and bring them into a single MQTT device

mekaneck commented 4 months ago

Couple suggestions which are somewhat related:

Change domains of all 8 entities (currently switch and sensor) to binary_sensor. This is the correct domain type for something that can only be monitored and not controlled from HA, and can only have a state of on or off (or true/false). Unless I've missed something and your intention is to enable HA to control the mute, video, hand raise, and background blur?
Create a common device for all entities so that they show up under the MQTT integration in HA.
- I see that the isinmeeting entity has a device defined, but the identifiers need to be a list "identifiers": [ "MyPrefix" ], instead of a string "identifiers": "MyPrefix",.
- All 7 other entities should have the same device dictionary (or at a minimum a device dictionary with the same identifiers list) in order to be grouped into the same device in HA.
- All keys should normally be all lowercase (e.g. device instead of Device) and make sure the underscores are correct (sw_version instead of SwVersion). See example in HA docs.

I've created auto-discovered MQTT entities in HA previously so if this is something you decide to implement let me know if I can answer any questions on it. I don't know C# but I am pretty familiar with HA.

jimmyeao commented 4 months ago

HA Can control the Mute, Video, Blur and hand raised (this is by design) but I'll look into your other suggestions. I'm OK with C# but mqtt/ha stuff is relativley new to me

jimmyeao commented 4 months ago

Almost there, will be pushed at weekend Entity names (and the device) currently use the prefix specified by the user (or the computer name if none specified)

jimmyeao commented 4 months ago

as an update, the next version will move to binary sensors, and add a new sensor for whether or not teams is running

mhoogenbosch commented 4 months ago

I see this is now working, i just updated to 346, which isn't in the release section yet. ;-)

But it works. Unfortunately i now have multipe sensors. Have to get rit of a few to push the new ones to the correct names so my automation's will work.

bluemryld commented 4 months ago

Yeah, we are working on cleaning up the sensors.

mhoogenbosch commented 4 months ago

Yeah, we are working on cleaning up the sensors.

I cleaned them myself with MQTT explorer, and all is fine now. Thanks !

jimmyeao commented 4 months ago

latest release has moved to binary sensors https://github.com/jimmyeao/TEAMS2HA/releases/tag/V1.1.0.501

jimmyeao / TEAMS2HA

Change domains to binary_sensor and bring them into a single MQTT device #39