jimmyhillis / slack-irc-plugin

Slack plugin to sync IRC with your slack.com account
MIT License
71 stars 40 forks source link

ability to chat to irc from slack #12

Open morenoh149 opened 9 years ago

morenoh149 commented 9 years ago

Is there any interest in adding the ability to use a slack outgoing webhook to communicate with this script. Then have this script speak to the irc channel. We would prefix the string with the initiating slack user's slack username.

morenoh149 commented 9 years ago

I could sleep knowing I could implement this. Please review this fork https://github.com/morenoh149/slack-irc-plugin/compare/jimmyhillis:master...master thoughts

this fork is consistent with the current slack incoming/outgoing webhook api. I'm currently running a slack channel where I can post to my private server and the server relays the message to irc and vice versa.

morenoh149 commented 9 years ago

just to confirm this is what slack instructed after creating the incoming webhook. I believe the current script does not follow these instructions because I couldn't get it to work. I may be wrong though team integration

jimmyhillis commented 9 years ago

This is a great idea. It's been in my plans for a long time (I have a branch started with it, but haven't finished it) so thank you for the effort. If you want to do a Pull Request I can give your code a review and we'll see what we can merge in? I might have a look at my outstanding branch as well and see if we can't come up with something between the two of them.

dylangrafmyre commented 9 years ago

Slack has changed the Incoming Webhook syntax. I had to edit slacker.js to reflect not needing a orgname and just using the token evironment variable which is now just a web hook url without the orgname and assigned token.

https://github.com/Dgrafmyre/slack-irc-plugin/commit/5d5bedc7b30c9a51a7597be99cd84fd060c0ba29

dwasyluk commented 9 years ago

This is awesome and exactly what I was looking for- thanks for the addition! Please issue a PR ;)

slash-zero commented 9 years ago

Is this feature fully implemented and functional? If so, this is great! Thanks for doing it.

morenoh149 commented 9 years ago

@slash-zero no. If you fix up the code make sure to push upstream

Jaykul commented 9 years ago

I've got it working using the slack bot hook (so there's only one "integration"). I can send you a PR

Pwn9 commented 9 years ago

This would be pretty cool..