search

jimmykane / fit-parser

Parse your FIT files easily, directly from JS (Garmin, Polar, Suunto)
Other
89 stars 33 forks source link

Negative temperature value turned into 255 #23

Closed collax closed 3 years ago

collax commented 3 years ago

Each negative temperature from my fit files are parsed as 255. (Using celsius)

jimmykane commented 3 years ago

Should be fixed with the latest Can you validate ?

collax commented 3 years ago

Thanks, it work.

JuanIrache commented 9 months ago

Hi. This seems to be happening again. I can share a sample privately

JuanIrache commented 3 months ago

This seems to have been fixed between NPM versions 1.8.5 and 1.9.0, and then broken again between 1.9.3 and 1.9.4.

I'm not sure what change broke this, as 1.9.3 doesn't seem to be on the main branch as 1.9.4

Edit: It seems this commit that was lost into oblivion fixes this: https://github.com/jimmykane/fit-parser/commit/f4a1255b05ccf4eb29e483e9e47ad3846aa90eff