search

jimmykane / fit-parser

Parse your FIT files easily, directly from JS (Garmin, Polar, Suunto)
Other
92 stars 33 forks source link

Update binary.js #29

Closed cgack closed 3 years ago

cgack commented 3 years ago

when running as a dependency in a Node.js lambda on AWS this change is required as buffer/ is not found "Runtime.ImportModuleError: Error: Cannot find module 'buffer/'"

thomaschampagne commented 3 years ago

Nice found !

tbsmark86 commented 2 years ago

Hi! This breaks the build for the browser for me (using snowpack). Because you switched from the 'buffer' package to 'buffer' internal node module ...

Not sure if this can be resolved for both cases. But would be nice :)

If you stay with this I suggest you also remove the 'buffer' dependency because well it's not used anymore.