search

jimmykane / quantified-self

Compare files from various activity trackers
GNU Affero General Public License v3.0
188 stars 24 forks source link

#212 - Add Github actions to deploy to firebase #216

Closed DoPaNik closed 3 years ago

DoPaNik commented 3 years ago

I haven't yet got around to setting up firebase correctly with everything (functions and co). Actually a rudimentary deployment should work so far. But I will continue to work on it - but maybe early feedback would be valuable.

jimmykane commented 3 years ago

@DoPaNik Hey thanks. Lets not worry so much about the functions. Lets get the hosting deployed.

On travis one thing I had was only when a tag was pushed would deploy. Not essential but in this way you would bump the version, tag and deploy.

What do you think about this?

DoPaNik commented 3 years ago

@jimmykane Unfortunately the functions block the deploy process for me. That's why i couldn't really test the hosting.

I like the idea with the tags! I will integrate this also in this action later :-)

jimmykane commented 3 years ago

@DoPaNik How do the functions deployment fail? (I haven't tested the pr yet).

We could also , seperate the project (but that might be too much)

DoPaNik commented 3 years ago

@jimmykane no, I think so is the project structure okay. But I have not yet configured firebase in a way that everything works and I have not yet understood everything completely. I am on it ;)

DoPaNik commented 3 years ago

@jimmykane now it can be deployed to firebase via github actions. The action is only started if a 'sem tag` is assigned. e.g. v6.8.5

jimmykane commented 3 years ago

Looks good. But 1 question. Do you prefer the v1.0.0 or 1.0.0 version formating.

Up to this point I have ommited the v just because I find it redundant, but I had used it in the past on some tags accidnetaly.

Should I modify the PR to use non-v tags?

jimmykane commented 3 years ago

I could also change how the tags are named on the repo.....

DoPaNik commented 3 years ago

Looks good. But 1 question. Do you prefer the v1.0.0 or 1.0.0 version formating.

Up to this point I have ommited the v just because I find it redundant, but I had used it in the past on some tags accidnetaly.

Should I modify the PR to use non-v tags?

Of course you're right, especially with the tags it's kind of redundant, but if the version appears alone somewhere else, then it's obvious that it's a version number. That's why I would rather tend to include the V in the naming.

jimmykane commented 3 years ago

Hey I merged this and will test on next release

btw have you checked this: https://github.com/marketplace/actions/github-action-for-firebase ?

jimmykane commented 3 years ago

Oh and this https://github.com/marketplace/actions/deploy-to-firebase-hosting :-D

DoPaNik commented 3 years ago

Oh I only tried this one -> https://github.com/jimmykane/quantified-self/pull/216/commits/830433880f9d415b0e12e5ac0ab601170e3d430c I just didn't understand why i should use such a plugin, which needs loading time, if I don't need the overhead at all - and in case of my choosen plugin I can't even add parameters 🤣

jimmykane commented 3 years ago

Alright no worries I was just speaking out loud. I ll give this a try asap but first I have to fix a queue issue :-/