Multisport Distance not showing up

jimmykane / quantified-self

Compare files from various activity trackers

GNU Affero General Public License v3.0

188 stars 24 forks source link

Multisport Distance not showing up #221

Open evanodell opened 3 years ago

evanodell commented 3 years ago

Noticed the problem in this upload. The full distance shows up on the map and other data is available, but the distance values are given as 0km for the 2nd running section: https://quantified-self.io/user/fRf6bCiiKcWGtwF8dXYuUwJgnGe2/event/knDuomAgpurrfTQWyw7M

I'm happy to figure out a solution but I'm not sure what the best place to start is.

jimmykane commented 3 years ago

It it possible to make the link public so I can take a look ?

evanodell commented 3 years ago

Ah didn't realise I had it private. Should work now.

jimmykane commented 3 years ago

I see the issue :-)

I ll investigate and come back.

I also see another issue. The map has a great period marked as paused.

If you have a link from the original file (FIT) that would be great to check why so many pause/start events

evanodell commented 3 years ago

Here is the FIT file: 5e76296d33564d7a05716b96.fit.zip

evanodell commented 3 years ago

Probably had a lot of pause/start events because of autopause and me stopping a lot.

jimmykane commented 3 years ago

I see that apart from the fit file first session the other 2 don't have a total distance. Seeing that this is a Suunto, I ll file a bug with them.

However, I can fix this on the lib side. QS uses sports lib.

The fix is easy.

At some point the lib generates distance from the samples. But I have explicitly asked for 0 distance to be ignored. I can change it to try also for distance of 0.

Here: https://github.com/sports-alliance/sports-lib/blob/c1f4c814d8e3605980540dc4b7665a51c7a0c76b/src/events/utilities/activity.utilities.ts#L1052

jimmykane commented 3 years ago

Does this look correct?

evanodell commented 3 years ago

Yeah that looks correct, and matches with what Suunto itself reports: https://app.suunto.com/move/evanodell/5e76296d33564d7a05716b96/

jimmykane commented 3 years ago

Wait the fix is not out 🙏

I was just making sure

On Wed, 18 Nov 2020, 13:10 Evan Odell, notifications@github.com wrote:

Closed #221 https://github.com/jimmykane/quantified-self/issues/221.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jimmykane/quantified-self/issues/221#event-4010341038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJVX42KX3JAPFFWRNXB653SQO2TXANCNFSM4TYVH3QA .