search

jimmykane / quantified-self

Compare files from various activity trackers
GNU Affero General Public License v3.0
192 stars 25 forks source link

Adjust CSS to fix bug where last element became unaligned #233

Closed alehel closed 3 years ago

alehel commented 3 years ago

Activity details such as "Duration", "Moving time", "Distance", etc. currently have a minor bug where, in certain circumstances, the last element is not positioned correctly. For my user I'm able to reproduce this error by viewing "Hiking" activities (possibly others as well). Se "Total training effect" in images below for example.

current-offset _

current-offsett-small

Link to a public activity which has this issue: https://quantified-self.io/user/DUrrVK0qMVZO5TtAP0r6Ox2HVLD2/event/21715c3d0b84c115946ea0106f12ddd0f5c799310121b6a12e65d5b600bf5d88

In this PR I'm suggesting changes to the CSS to resolve this issue. Instead of using flex, I've changed it to use a grid based layout. Some minor changes to the appearance as a result. Bellow are two examples of how it looks after the change.

new

_

new-small

I also removed an empty section tag from this view. As far as I could tell, it didn't serve any purpose.

Hope these changes are welcome :)

jimmykane commented 3 years ago

Sorry for the time I took to respond.

Thank you very much