search

jimmyl0l3c / cfg_share_links

App for Nextcloud that adds the ability to specify share tokens
GNU Affero General Public License v3.0
32 stars 3 forks source link

Make compatible witn NC28 #182

Closed nursoda closed 7 months ago

ernolf commented 9 months ago

Meanwhile I removed my comment because I thought I was wrong but I have to repeat it, since I could reproduce it on various servers: I can create configured links, the links are stored and work but as long as the app is activated, the download of folders does not work. It offers a "download.php" instead of a zip file

komoricodrutz commented 9 months ago

Yes, please make compatible with NC28

GHBLoos commented 9 months ago

I use this feature a lot. It should be part of Nextcloud in my opinion. I hope this will be compatible soon with NC28, so I can update from NC27 to NC28.

ToS0 commented 8 months ago

Here is a workaround for now, and a patch on its way: https://github.com/nextcloud/server/issues/42200

ernolf commented 8 months ago

Here is a workaround for now, and a patch on its way: nextcloud/server#42200

This patch did indeed fix it on my various test servers. Has anyone else encountered problems since?

@jimmyl0l3c: so nothing would stand in the way of a release for 28, right?

ernolf

ToS0 commented 8 months ago

Works with 28.0.2 now -- no workaround needed anymore.

Ticket can be closed

GHBLoos commented 8 months ago

That's good news. I checked my admin - overview page, and there it says that it's not compatible with NC 28.0.2. image

I suppose it will work. But maybe something should be set to fix this warning.

nursoda commented 8 months ago

@GHBLoos As you can see in https://apps.nextcloud.com/apps/cfg_share_links, the maintainer has not released the app for NC 28 yet, so the message "not compatible" is correct.

GHBLoos commented 8 months ago

I understand. So this ticket should not yet be closed I quess. I hope the maintainer will create a new release soon.

ToS0 commented 7 months ago

You are right, the problem is not solved. Only listing folders works, but actually opening contents does still not work. So the workaround from above (Federated Cloud Sharing) is still needed.

GHBLoos commented 7 months ago

I would love to update to NC 28, but since I use this app so much, I am still on NC27. I am curious if the problem is within the app, or the problem is in NC28? In other words, who has to fix the code?

nursoda commented 7 months ago

@jimmyl0l3c Please tell us if we can help and how since NC29 is about to be released end of April (string freeze in a week) NC26 will be EOL in a couple of days and sharerenamer is not being updated at all.

jimmyl0l3c commented 7 months ago

Hi, please try the new release (v5.0.0) and let me know if the problem persists.

ToS0 commented 7 months ago

Hi, please try the new release (v5.0.0) and let me know if the problem persists.

Hey, great, works now again without the workaround. Thank you!

nursoda commented 7 months ago

Thanks for the release. Is there a reason not to set max-version including 29?

GHBLoos commented 7 months ago

Thanks you!

jimmyl0l3c commented 6 months ago

Thanks for the release. Is there a reason not to set max-version including 29?

I need to test it properly, but dont have it setup yet. I'll try to release a compatibility patch before NC 29 releases.