search

jimmymcp / al-test-runner

VS Code Extension to help run AL tests against Business Central container
https://jpearson.blog/al-test-runner-for-visual-studio-code/
MIT License
11 stars 16 forks source link

Remove BOM from app.json #123

Closed jwikman closed 6 months ago

jwikman commented 7 months ago

In some of our apps we seem to have the app.json file saved as UTF8-BOM. Don't ask me why they are saved like that, it seems to be unintentionally changed by some user in some cases. Maybe some extension that are doing something, I don't know...

That BOM does not have any impact when developing in AL nowadays, except when using AL Test Runner. And the issue is quite annoying and you have no idea on what is being wrong, since the test runner is just hanging... (see https://github.com/jimmymcp/al-test-runner/issues/48 for more details)

This little change removes any BOM from the app.json data before parsing the content.

I hope you can consider merging this. 🙂

Cheers, Johannes

jwikman commented 6 months ago

@jimmymcp, is this something you might consider? 🙂

jimmymcp commented 6 months ago

Thanks for the contribution Johannes!

I've been on holiday this past week but I will get a new pre-release version out tomorrow with your changes included.

Cheers, JP

jwikman commented 6 months ago

Thanks Jimmy!

I've got a few more changes/improvements in another branch that I did when troubleshooting why I did not get AL Test Runner to work in my environment. I'll create another PR with this later, and we'll see what you think about those changes.