search

jimmynotjim / scrollnav

A dependency free JavaScript plugin for auto generating single page navigation
http://scrollnav.com
MIT License
461 stars 127 forks source link

Added a new parameter az default option to define target element #21

Closed MeghdadHadidi closed 11 years ago

MeghdadHadidi commented 11 years ago

1- 'target' added as default option and it's value set to this 2- A variable named '$target' defined 3- In the function named 'insertNav', '$container' replaced with '$target' 4- '$container' in lines 199 and 222 has been changed w/ '$target' 5- Now it works and 'appendTo', 'prependTo' also can set as 'location' value

jimmynotjim commented 11 years ago

Thanks for updating the PR. If you could make the changes I just outlined and pull the 2.0 branch again (right now you're slightly behind the 2.0 branch) I can merge this in and build some tests.

MeghdadHadidi commented 11 years ago

Hi Jimmy Thanks for your comments Ok, I'll do it now Although I'm new in Github and may take some time to match with this system

On Mon, Oct 7, 2013 at 3:56 PM, Jimmy Wilson notifications@github.comwrote:

Thanks for updating the PR. If you could make the changes I just outlined and pull the 2.0 branch again (right now you're slightly behind the 2.0 branch) I can merge this in and build some tests.

— Reply to this email directly or view it on GitHubhttps://github.com/jimmynotjim/scrollNav/pull/21#issuecomment-25804207 .

jimmynotjim commented 11 years ago

No worries about github experience, everyone starts somewhere. If you have any questions, feel free to ask. I'll be pushing updates to the 2.0 branch all day today, so just make sure you pull my 2.0 branch into yours just before you push yours up again. This page explains how upstream (my version of the branch) can be pulled into origin (your version of the branch) https://help.github.com/articles/fork-a-repo#step-3-configure-remotes