search

jimmynotjim / scrollnav

A dependency free JavaScript plugin for auto generating single page navigation
http://scrollnav.com
MIT License
461 stars 127 forks source link

Destroy method / off() to remove scrollNav from element? #28

Closed michael-benin-CN closed 11 years ago

michael-benin-CN commented 11 years ago

Is there a destroy method implemented?

jimmynotjim commented 11 years ago

No but you have some great timing, I was just thinking about this over the weekend. I probably won't have time to implement for at least a week (currently traveling), so if you're impatient feel free to send a PR.

michael-benin-CN commented 11 years ago

Ok, I'll look into it. Thanks for the quick reply!!

jimmynotjim commented 11 years ago

You caught me while I'm waiting to get off a plane, not much else to do but check my email :)

jimmynotjim commented 11 years ago

Just a heads up that I'm going to tackle this issue this weekend. It's going to require a little reorganizing, so hopefully I'll be able to release it next Monday.

jimmynotjim commented 11 years ago

@michael-benin-CN Mind taking a look at #31 and let me know what you think? Thanks.

jimmynotjim commented 11 years ago

Tested and merged to v2.1.0 pre-release. Feel free to use that branch for the time being. 2.1 will probably go live at the end of the week.