search

jimmywarting / StreamSaver.js

StreamSaver writes stream to the filesystem directly asynchronous
https://jimmywarting.github.io/StreamSaver.js/example.html
MIT License
3.97k stars 413 forks source link

zip64 support #240

Open starli-sl opened 3 years ago

starli-sl commented 3 years ago

The zip.js has support zip64. If we can merge the changes from the zip.js, we may able to get rid of the 4G size limit. https://github.com/gildas-lormeau/zip.js/pull/206

magnus-rattlehead commented 2 years ago

I think I have implemented it in my fork (https://github.com/magnus-rattlehead/StreamSaver.js) , check it out, and if there are fixes/improvements to be made let me know and I'll make a PR.

christianwengert commented 2 years ago

@magnus-rattlehead Thanks for writing this. Did you test this so far? The file saving-multiple-files.html throws an error. Did you manage to run this? I will also have a look into it

magnus-rattlehead commented 2 years ago

@christianwengert Fixed some of those syntax errors in the latest commit. I'm testing with large files right now and everything looks good, but I'm not sure if this is the code or my internet connection, downloads take forever. Feel free to test/review. If all looks good ill make a PR on the main repo.

magnus-rattlehead commented 2 years ago

Looks like there are problems with large files. They stop downloading at 4,506,484,525 bytes. I assume this is a problem with my implementation of zip64 code. I'll look into it later

EDIT: I think I fixed it. My latest commit to my fork should be working. Feel free to test it on your end.