Update ssdp and allow specification of bind ports

jimmywarting / wemo-client

JavaScript client library for controlling and subscribing to Wemo Devices

MIT License

132 stars 40 forks source link

Update ssdp and allow specification of bind ports #40

Closed driskell closed 8 years ago

driskell commented 8 years ago

I did a PR into node-ssdp to allow specifying which port to bind to for discovery as I need to be able to run these libraries behind a firewall as the default 0 picks a random available port.

This PR adds ability to specify the ports to wemo-client to use for event listening, and also for discovery.

Thanks!

codecov-io commented 8 years ago

Current coverage is 89.96% (diff: 100%)

Merging #40 into master will increase coverage by 0.07%

@@             master        #40   diff @@
==========================================
  Files             2          2          
  Lines           267        269     +2   
  Methods          57         57          
  Messages          0          0          
  Branches         40         43     +3   
==========================================
+ Hits            240        242     +2   
  Misses           27         27          
  Partials          0          0

Powered by Codecov. Last update 2a0fd44...a2e9cc2

timonreinhard commented 8 years ago

Nice feature, thank you!

driskell commented 8 years ago

You're welcome :) It'll be great to see this in a release soon 👍 Thanks for looking after this great project! :)

timonreinhard commented 8 years ago

Thanks for the follow-up. It's now in released in v0.11.0