search

jimmywarting / wemo-client

JavaScript client library for controlling and subscribing to Wemo Devices
MIT License
132 stars 40 forks source link

Implement a setAttribute(s) function #48

Closed franko-s closed 7 years ago

franko-s commented 7 years ago

I think it'd be nice to be able to set attributes for the wemo maker. Has anyone played around with the setAttribute API?

I tried but had issues with the payload.

timonreinhard commented 7 years ago

My first idea is, that this is already covered by setBinaryState, not sure what else one could do with the Maker. But anyway, I'm open for any pull-requests addressing this.

franko-s commented 7 years ago

I guess the wemo maker attributes (for both momentary connection and toggle switch) aren't treated as binary states. I'll try to implement setAttribute and create a PR.

timonreinhard commented 7 years ago

Closing due to inactivity.