search

jimmywarting / wemo-client

JavaScript client library for controlling and subscribing to Wemo Devices
MIT License
132 stars 40 forks source link

Added callback if an error occurs during Wemo.load #51

Closed lutas closed 7 years ago

lutas commented 7 years ago

Errors were being dropped from the internal callback which means calling code can't see them. I've added an optional extra parameter for the callback to deal with this case.

codecov-io commented 7 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.49%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   87.09%   87.58%   +0.49%     
==========================================
  Files           2        2              
  Lines         279      282       +3     
  Branches       46       47       +1     
==========================================
+ Hits          243      247       +4     
+ Misses         36       35       -1
Impacted Files Coverage Δ
index.js 81.17% <100%> (+0.68%) :arrow_up:
client.js 90.35% <0%> (+0.5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f21ed18...3a1e2eb. Read the comment docs.