Closed benburkhart1 closed 7 years ago
Merging #52 into master will decrease coverage by
1.17%
. The diff coverage is20%
.
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 87.58% 86.41% -1.18%
==========================================
Files 2 2
Lines 282 287 +5
Branches 47 47
==========================================
+ Hits 247 248 +1
- Misses 35 39 +4
Impacted Files | Coverage Δ | |
---|---|---|
index.js | 81.17% <ø> (ø) |
:arrow_up: |
client.js | 88.61% <20%> (-1.75%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fd9045b...2358007. Read the comment docs.
That looks like a great addition, thank you! It's cool that you also took care of fixing the examples which broke in c9c8542692337016596dae7db7cbf7974ba1a57b. One thing: Can you please add the newly supported devices to the README.md
?
Hello @timonreinhard,
I did have it in the bullet point list, but did not document the new method. I completed that as well as corrected another foundDevice callback issue. Let me know if anything else needs changed.
Thank you very much for your contribution!
This utilizing the existing attributeList event for tracking how the Humidifier/HeaterB, and adds a SetAttributes call, which allows you to switch modes, set remaining timers, and desired humidity/temp.
Additionally I noticed the examples were not working, and found it was due to an 'err' being passed as the first arg to the foundDevice callback.
Added examples of the Humidifier/HeaterB.
(I additionally have a WeMo crockpot that I figured out how it works, but need to implement it in your library)