jimmywarting / wemo-client

JavaScript client library for controlling and subscribing to Wemo Devices
MIT License
132 stars 40 forks source link

Add support for device brightness #61

Closed KaidenR closed 6 years ago

KaidenR commented 6 years ago
KaidenR commented 6 years ago

Oh, and I've been testing this with a Wemo Dimmer switch I got the other day and it seems to work great.

codecov-io commented 6 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.54%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   86.41%   86.95%   +0.54%     
==========================================
  Files           2        2              
  Lines         287      299      +12     
  Branches       47       49       +2     
==========================================
+ Hits          248      260      +12     
  Misses         39       39
Impacted Files Coverage Δ
client.js 89.25% <92.85%> (+0.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 718cb99...adcd0d5. Read the comment docs.

timonreinhard commented 6 years ago

Thanks a lot for contributing and sorry for the late response. Cool addition!

KaidenR commented 6 years ago

@timonreinhard Thanks for the merge! Will you be able to do a release soon?

timonreinhard commented 6 years ago

Yes, will release within the next 10 days.

KaidenR commented 6 years ago

@timonreinhard Just a quick bump to see if we can get a new version released. We're waiting for this release to add dimming in another project (https://github.com/rudders/homebridge-platform-wemo/pull/122)

timonreinhard commented 6 years ago

@KaidenR Thanks for keeping me from procrastinating, it's out now ;-)