search

jimniels / teamcolors

Team Colors for professional sports teams
https://teamcolors.jim-nielsen.com
137 stars 64 forks source link

Update Mancester City to 2016 crest & colors #71

Closed scottarnold closed 7 years ago

scottarnold commented 7 years ago

The colors are taken from their site and aren't "official"

jimniels commented 7 years ago

Nice, thanks for the logo and color updates! The data and design asset updates look good to me. I only see two small things that could use revisions:

  1. I don't think there's a need to re-commit the compiled build/scripts/index.js file. Your suggested updates only touch a team's logo and it's colors. That means it should only affect the teams.json file, the team's .svg logo, and the source .sketch file. So I'd say just remove that file's changes from the PR.
  2. I don't see any need for the index.js.map file.
scottarnold commented 7 years ago

Done!

jimniels commented 7 years ago

Awesome, thanks for the update! Changes are live