Fix for pre,post,prelink commands , relative includes and other fixes to make it more similar to how premake gmake2 works.

jimon / premake-ninja

Premake extension to support Ninja

MIT License

58 stars 17 forks source link

Fix for pre,post,prelink commands , relative includes and other fixes to make it more similar to how premake gmake2 works. #35

Closed LostbBlizzard closed 1 month ago

LostbBlizzard commented 1 month ago

Fixed defualtplatform not using defualtplatform when set.
Fixed prebuild commands runing even when its project dependencies are not built.
Fixed project c and c++ includes not being relative to the location property.
Fixed project pre,post,prelink not runing in the working working directory of location property.

I havent updated forceincludes because i didn't use them in project and this pull request is a bit messy.I will fix it after this pull request.

Jarod42 commented 1 month ago

Can you split the PR by fix?

Paths (as includedirs) from toolset should be fixed now when workspace location != project location. pre/post build command might still be an issue though. UTs fail, I didn't check if issue come from core or your PR.

LostbBlizzard commented 1 month ago

I'll spit PR when I get home. Sorry I didn't see the message till today.

LostbBlizzard commented 1 month ago

pull request was split

(fixed buildcommand not haveing project working directory)[https://github.com/jimon/premake-ninja/pull/39]
(fixed includedir not being relative from the cfg.workspace.location)[https://github.com/jimon/premake-ninja/pull/38]
(fixed missing prefix in getFileDependencies)[https://github.com/jimon/premake-ninja/pull/37]
(fixed defaultplatform not being selected when set)[https://github.com/jimon/premake-ninja/pull/36]

Theses one more fix but depends on fixed missing prefix in getFileDependencies see https://github.com/jimon/premake-ninja/pull/37