search

jimon / premake-ninja

Premake extension to support Ninja
MIT License
58 stars 17 forks source link

fixed missing prefix in getFileDependencies #37

Closed LostbBlizzard closed 1 month ago

LostbBlizzard commented 1 month ago

this pull request fixes the issue of getFileDependencies not haveing the correct dependency as the function get_key on 32 on ninja.lua adds the prefix if cfg.platform is set as seen below

local function get_key(cfg, name)
    local name = name or cfg.project.name

    if cfg.platform then
        return name .. "_" .. cfg.buildcfg .. "_" .. cfg.platform
    else
        return name .. "_" .. cfg.buildcfg
    end
end

while getFileDependencies did have this prefix breaking some projects. while gmake2 would build them just fine.

LostbBlizzard commented 1 month ago

Also prebuild commands don't include project dependencies. Allowing them to run before there built.I cant do a pull request as it relies on this pull request.