search

jimouris / draft-mouris-cfrg-mastic

Specification of the Mastic Verifiable Distributed Aggregation Function (VDAF)
https://datatracker.ietf.org/doc/draft-mouris-cfrg-mastic/
Other
1 stars 1 forks source link

Consider using a git submodule for the upstream reference code #1

Closed cjpatton closed 1 year ago

cjpatton commented 1 year ago

The reference code makes use of code from the VDAF repository. Copy-pasting code from there will be hard to maintain long-term, as it gets updated from time to time. (We actually cut the next draft draft-irtf-cfrg-vdaf-06, which you'll need to catch up to.)

One way to solve this problem is using git submodule. The idea is that you can checkout code from another git repository in a folder in this repository. This would allow you to import that code directly here.

jimouris commented 1 year ago

Thanks for the comment, that's a great suggestion. Will do!

jimouris commented 1 year ago

So I've been thinking about this a bit. Should I have the whole VDAF git repo as a submodule here or can I just have the code somehow? Is there any clean way to do this?

cjpatton commented 1 year ago

I created a PR to close this one!