investigate aiohttp in place of httpx

jimpastos / ha-modernforms

ModernForms Smart Fan Integration for HomeAssistant

MIT License

12 stars 6 forks source link

investigate aiohttp in place of httpx #18

Closed faceprint closed 3 years ago

faceprint commented 3 years ago

Investigate using aiohttp in place of httpx due to some quirks with read timeouts.

icemarkom commented 3 years ago

FYI - I think aiohttp works fine. I have no objections to replace httpx with it.

icemarkom commented 3 years ago

I've been running this for a few weeks now, and it's rock solid stable (fans still crash, but I do not believe it's related). Any chance you can send a PR, so we can move on? :-)

faceprint commented 3 years ago

I filed https://github.com/jimpastos/ha-modernforms/pull/19 with everything pushed to my fork. It's got multiple changes, I don't hve time to separate them out, but if you or anyone wants to just merge pieces, I have no objection.