jimporter / bfg9000

bfg9000 - build file generator
https://jimporter.github.io/bfg9000
BSD 3-Clause "New" or "Revised" License
76 stars 21 forks source link

Example 03_options does not build #111

Closed Ipsum closed 5 years ago

Ipsum commented 5 years ago

Hey I'm on arch linux

cd 03_options && mkdir build && 9k build

fails with the error

build.bfg:14: 'Environment' object has no attribute 'target_platform'

Building a .bfg_environ seemed to have no benefit.

jimporter commented 5 years ago

What is 9k --version? Sounds like you're running examples from master on bfg v 0.3.1 (or lower).

Ipsum commented 5 years ago

Yea, thats the problem - I used the package on pip which is 0.3.1. Do you have a packaged version that is newer?

jimporter commented 5 years ago

Since it's an ordinary setuptools project, bfg is pretty easy to install from a git checkout: just run pip install . from the root of the repo. Alternately, you can use the examples from the v0.3.1 tag, which should all work; every example project is automatically tested in CI (I think).

There's a minor issue where the docs for previous releases point to the examples dir of the master branch on Github, but I haven't come up with a good way to fix that which doesn't involve a lot of micro-management on my part.

Ipsum commented 5 years ago

Understood, I think we can make do with the packaged version for now and wait for a new release.

I think the doc issue is what was throwing me off. I'd honestly chock it up to my idiocy and not change anything, but I likely would have been less thrown off if the default branch on github was the packaged version instead of master.

jimporter commented 5 years ago

This is something that mike should probably handle, since it already does a lot of versioning stuff, and there's info there available to do some kind of redirection to the appropriate tag on Github. I'll have to think about how to do it though...