jimporter / bfg9000

bfg9000 - build file generator
https://jimporter.github.io/bfg9000
BSD 3-Clause "New" or "Revised" License
76 stars 21 forks source link

Provide compatibility shim for `find_files()`? #137

Closed jimporter closed 4 years ago

jimporter commented 4 years ago

129 significantly changes the way find_files(), find_paths(), and related functions (directory()/header_directory()) work. It would be nice to provide a compatibility shim so that common uses of these functions in bfg v0.5 code works in v0.6. However, this is a fair amount of effort to do, and maybe it'd be ok to just require people to update their code. We haven't hit 1.0 yet, and there aren't that many active users, so a compatibility break like this isn't too catastrophic. Still, I'd prefer not to break things this severely very often...

jimporter commented 4 years ago

One idea: since we have bfg9000_required_version, I could keep track of that and use it to decide which implementation of find_files() to expose. If the build file requires 0.6, then we use the new form; otherwise, we use the old one and emit a warning that it'll go away entirely in 0.7.