I find this hard to test on the level of unit-tests b/c of the subprocess, IMHO this is more an integration check with the git utility and the environment. git/git-fast-import should work as expected. Perhaps a suite that supports setting the environment and binaries w/ a git repo fixture to poke around with.
jimporter
commented
2 years ago
Update w/ lint fix and on top of master.
Regarding tests, "upstream" ghp-import took in the change already and at the end of the issue description there I left some notes on how I tested it if it helps.
I find this hard to test on the level of unit-tests b/c of the subprocess, IMHO this is more an integration check with the git utility and the environment. git/git-fast-import should work as expected. Perhaps a suite that supports setting the environment and binaries w/ a git repo fixture to poke around with.