search

jimradford / superputty

The SuperPuTTY Window Manager for putty sessions
https://www.facebook.com/superputty
MIT License
1.9k stars 320 forks source link

Restart session feature doesn't work #924

Open Kyogre opened 7 months ago

Kyogre commented 7 months ago

Describe the bug Nothing happens when I perform Restart session on a tab.

To Reproduce Steps to reproduce the behavior:

  1. in SP connect to any ssh session (I am using SP with combination of kitty portable v0.76.1.13)
  2. open context menu of any tab
  3. press Restart session
  4. Nothing happens

Expected behavior Session restarts

Desktop (please complete the following information):

pkumarg commented 6 months ago

Are you trying to restart session when it's already connected? Because on already started session which just working find this option is not valid. Ideally it should be greyed out if session is started and not interrupted by any means.

Kyogre commented 6 months ago

restart session when it's already connected?

Yes.

on already started session which just working find this option is not

No no no. Maybe the user can't exit vim and just want to restart the session? 🙃 Anyway in kitty this feature is working fine.

pkumarg commented 6 months ago

OK, if that's the requirement, then I think we need a fix. Anyway it looks kitty supports this kind of restart, and putty doesn't even show this option when session connected.

And it could be possible that SuperPutty is mostly tested with putty. That's why there is no action on session restart click when connected.