jimsalterjrs / sanoid

These are policy-driven snapshot management and replication tools which use OpenZFS for underlying next-gen storage. (Btrfs support plans are shelved unless and until btrfs becomes reliable.)
http://www.openoid.net/products/
GNU General Public License v3.0
3.14k stars 308 forks source link

fix "creation"/"guid" regex detection #859

Closed jan-krieg closed 10 months ago

jan-krieg commented 1 year ago

Some of the regexes to detect lines containing the creation or guid property also select lines where the snapshot / bookmark name contains either creation or guid. Fixed by requiring a tab right before creation or guid.

Note that I've only specifically tested this issue for snapshots, though from the code it seems obvious that the same bug applies to bookmark as well, hence also changed those regexes as as well.

Fixes #858

phreaker0 commented 1 year ago

look good, thx

jimsalterjrs commented 10 months ago

needs rebase

phreaker0 commented 10 months ago

rebased