jimschubert / NewTab-Redirect

NewTab Redirect! is an extension for Google Chrome which allows the user to replace the page displayed when creating a new tab.
MIT License
479 stars 88 forks source link

Redraw and other issues? #224

Open barancig opened 8 months ago

barancig commented 8 months ago

I've used this extension with Chrome for many years on several computers. I've found that when the extension is enabled, it sometimes creates screen redraw issues, certain 2FA prompts won't load properly (can't consistently log into LastPass with 2FA enabled or consistently use Duo). Generally shutting Chrome and relaunching allows me to access those functions/resolves the redraw (e.g. sites like Amazon, Chase and others not loading properly). With a lot of trial and error, I isolated this issue to NTR. This has been happening for years (I just wasn't previously able to isolate to NTR) so I'm guessing maybe this is a setting issue rather than a bug of some kind? Any suggestions on how to fix this?

jimschubert commented 8 months ago

NTR doesn't do anything related to the "chrome" part of the browser. In fact, extensions and page level access work in a completely different physical boundary in the browser than the code which functions at the browser interface level. Even if there was an issue, NTR redirects then immediately no longer exists in memory (for the redirect page). Chrome does maintain an extension icon for all loaded extensions but that shouldn't have anything loaded from the extension other than the icon - everything else is browser UI managed by Chrome.

I have no idea of any setting which would change this behavior you've described, because doing so would be a severe security risk for Chrome users if extensions were able to control or manipulate the UI components. It sounds to me to be memory related, which is the reason I personal left Chrome years ago (it's a hog even without extensions installed).

If you're doing something weird like loading an iframe within your new tab page, then I could see how that might cause a memory leak or something, but that would be an issue with the browser itself and not the extension. You really shouldn't be using iframes in general, though.

You could maybe try a greatly simplified new tab extension. I have an example and instructions here: https://github.com/jimschubert/duckduckgo-newtab. You'd just need to change from ducksuckgo in the override.html to your desired page. Of course, you don't get setting sync or extension updates/sync via your Google account, but it'll solve the other performance issues you describe.

I haven't used Chrome as my daily browser for about 4 years, and only use it on the rare occasion that a site doesn't work appropriately on Firefox. I haven't noticed issues with performance, even though I do usually have the browser open at all times. I'll keep an eye out for other reports related to performance, though.

barancig commented 8 months ago

Thank you. I’m afraid this is technically over my head, but I get the general messsge that my issues are not likely being caused by your extension. I will continue to try to isolate the issue.


From: Jim Schubert @.> Sent: Thursday, November 16, 2023 10:17:34 PM To: jimschubert/NewTab-Redirect @.> Cc: barancig @.>; Author @.> Subject: Re: [jimschubert/NewTab-Redirect] Redraw and other issues? (Issue #224)

NTR doesn't do anything related to the "chrome" part of the browser. In fact, extensions and page level access work in a completely different physical boundary in the browser than the code which functions at the browser interface level. Even if there was an issue, NTR redirects then immediately no longer exists in memory (for the redirect page). Chrome does maintain an extension icon for all loaded extensions but that shouldn't have anything loaded from the extension other than the icon - everything else is browser UI managed by Chrome.

I have no idea of any setting which would change this behavior you've described, because doing so would be a severe security risk for Chrome users if extensions were able to control or manipulate the UI components. It sounds to me to be memory related, which is the reason I personal left Chrome years ago (it's a hog even without extensions installed).

If you're doing something weird like loading an iframe within your new tab page, then I could see how that might cause a memory leak or something, but that would be an issue with the browser itself and not the extension. You really shouldn't be using iframes in general, though.

You could maybe try a greatly simplified new tab extension. I have an example and instructions here: https://github.com/jimschubert/duckduckgo-newtab. You'd just need to change from ducksuckgo in the override.html to your desired page. Of course, you don't get setting sync or extension updates/sync via your Google account, but it'll solve the other performance issues you describe.

I haven't used Chrome as my daily browser for about 4 years, and only use it on the rare occasion that a site doesn't work appropriately on Firefox. I haven't noticed issues with performance, even though I do usually have the browser open at all times. I'll keep an eye out for other reports related to performance, though.

— Reply to this email directly, view it on GitHubhttps://github.com/jimschubert/NewTab-Redirect/issues/224#issuecomment-1815684463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDSEPYZTRSPWINS3F7NKQXLYE3JM5AVCNFSM6AAAAAA6S5C2TOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVGY4DINBWGM. You are receiving this because you authored the thread.Message ID: @.***>