search

jimsimon / pub_client

A library for interacting with the REST API for Pub (pub.dartlang.org).
Apache License 2.0
9 stars 10 forks source link

Any plans to make this library dart 2 compatible? #1

Closed martflu closed 6 years ago

martflu commented 6 years ago

It is depending on dartson which is depending on barback which is deprecated in dart 2. You could use codable to replace dartson. If you don't have the time, I would be willing to create a PR. I just want to make sure first that you are still maintaining this library.

jimsimon commented 6 years ago

I haven't touched this library in awhile since I don't use Dart all that much anymore. I'm willing to update it if you find it useful though I'm not even sure if the client methods still point to legitimate pub API endpoints.

I'd probably switch to json_serializable to eliminate the dependency on mirrors. I can do some work on this in the next week or so.

On Tue, Aug 7, 2018, 6:34 AM Martin Flucka notifications@github.com wrote:

It is depending on dartson which is depending on barback which is deprecated in dart 2. You could use codable https://pub.dartlang.org/packages/codable to replace dartson. If you don't have the time, I would be willing to create a PR. I just want to make sure first that you are still maintaining this library.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jimsimon/pub_client/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJiz9Kd4-LyPQ_hYqABi3dMdIpb87JYks5uOW0bgaJpZM4Vx57I .

martflu commented 6 years ago

We are not super dependent on it but it is the only library with that functionality. json_serializable looks usefull thanks!

jimsimon commented 6 years ago

@martflu I've pushed up a new version that requires Dart 2. You'll need to update to pub_client 2.0.0 to use it. Let me know if you run into any issues. :)

enyo commented 6 years ago

Thanks @jimsimon !