jimsug / pokemon-hangouts-bot-plugins

Pokemon related plugins for hangoutsbot/hangoutsbot
2 stars 3 forks source link

To-do list for pokemon.py #1

Open jimsug opened 8 years ago

jimsug commented 8 years ago
MTRNord commented 8 years ago

I am getting on the task to support multi language support for the pokemon name. Maybe I will get that done maybe not. If it goes well I will send an Pull :)

MTRNord commented 8 years ago

Code for translation is here: https://github.com/MTRNord/pokemon-hangouts-bot-plugins/blob/patch-1/pokemon.py#L171 It does not work completly yet but I am working at it.

jimsug commented 8 years ago

@MTRNord

Code for translation is here: https://github.com/MTRNord/pokemon-hangouts-bot-plugins/blob/patch-1/pokemon.py#L171 It does not work completly yet but I am working at it.

There's possibly a case here that if you're using a different language, you could cache the entire dataset of pokemon and then call the API for every pokemon in existence. The issue there is that you'd need to do this for every type, and nature as well - that's probably about 900 calls to the API?

But then - you could make this run in batches, with exponential backoff, and then cache it incredibly heavily - I'm thinking months if not a year or so - new Pokemon aren't released that often.

This is an idea I could work with.

MTRNord commented 8 years ago

I am still working on it and the devs of the API already working on an List over the Api. (I asked them about this). With this API it would be much faster and easier.