Request for Data - Githubissues

MTRNord commented 8 years ago

Hi I use this plugin in an Pokemon Go chat and it works very great :+1: but some the following Data's would be really nice to have: (i have linked them in the docs)

I think personaly that both can just go with the pokedex command

jimsug commented 8 years ago

Thanks - I'll probably include it as a config option, where you can specify how much information you want the bot to output.

jimsug commented 8 years ago

acbaf98 adds abilities to the output - you now need some additional configuration in your bot's config:

'pokedex':{
  'info':[
    'types',
    'ability'
  ]
}

The new pokedex configuration setting tells the bot what to do. Currently it accepts one or both of types and ability and is set on plugin (re)load for simplicity but I may allow this to be set per-hangout. This would mean caching all data, even if it's not going to be used.

When you change this configuration and reload the plugin, the bot will wipe the cache and start again. This is in order to keep the cache small, and for simplicity (so the bot won't look for abilities if we haven't cached it). I could arguably only do it one-way (maybe in a future push).

While I suppose each botmaster will decide whether they have the capacity to cache all data (and perhaps I should have made the bot cache all data from the start), it seems silly to cache things you'll never use.

Also, a short pokedex entry is a good one - while I might be able to put switches in for everything, it's probably not worthwhile until I build some global/per-hangout defaults into the bot to account for generational differences, etc.

As for natures - this would almost certainly need to be in another command (I'm thinking `/bot pokemon natures'), and I'm trying to decide how best to do that. At the moment there are only 25 natures and I don't think it's going to have many additions very frequently, so I plan on caching this very aggressively to be API-friendly, as well as for performance issues.

This will probably go into a separate memory entry (pokemon_natures or something) so that it doesn't get wiped at the same time as the cache when the bot wipes it on config changes.

jimsug commented 8 years ago

2e54272 adds the /bot pokemon nature <nature-name> command.

Currently it will cache data the same way as Pokemon calls.

~ /bot pokemon nature Jolly
Jolly
10%+ Speed
10%- Special-Attack

~ /bot pokemon nature quirky
Quirky
Quirky does not increase any stat.
Quirky does not decrease any stat.

jimsug / pokemon-hangouts-bot-plugins

Request for Data #2