search

jimsynz / faye-rails

Simple Rails glue for the Faye messaging protocol.
MIT License
435 stars 79 forks source link

Backward-compatible Rails 4 route mapper compatibility #54

Closed nilbus closed 10 years ago

nilbus commented 10 years ago

There has been discussion in #42 of moving to a rack-based routing solution, but that has not been resolved, and Rails 4 is out now. This change would also require a major version bump, thus leaving 1.x incompatible with Rails 4.

This patch adds the required :via option for Rails >= version 4, but not for Rails 3, which does not support (nor need) :via.

nilbus commented 10 years ago

This is tested manually with Rails 4. Please test with Rails 3, though I'm confident that it will work there too.

You are correct that this deserves better automated testing, but I was not successful in my attempt to test with both a rails3 and rails4 dummy project.

felixbuenemann commented 10 years ago

:+1: Working fine with rails 3.2.16 and 4.0.2.

nilbus commented 10 years ago

@jamesotron Are we clear to merge and release this?

felixbuenemann commented 10 years ago

@nilbus James told me he's taking a time off from OSS until January.

jimsynz commented 10 years ago

Looks good. Thanks!

nilbus commented 10 years ago

Thanks for reviewing it. Do you have an estimated timeline for your next release?

jimsynz commented 10 years ago

I'm basically hands-off on all OSS at the moment, so just doing maintenance mode. I'll make you a collab if you want and you can get it ready for release.

jimsynz commented 10 years ago

Turns out you are a collaborator already. Just get it ready for release and let me know when to git pull and rake release.

nilbus commented 10 years ago

Will do. I'll make sure everything is ready and let you know.

jimsynz commented 10 years ago

Cheers.