removed middleware's 'server' param restriction to only allow 'passenger'

jimsynz / faye-rails

Simple Rails glue for the Faye messaging protocol.

MIT License

435 stars 79 forks source link

removed middleware's 'server' param restriction to only allow 'passenger' #83

Closed cloocher closed 9 years ago

cloocher commented 9 years ago

1) underline 'faye-websocket' gem supports 5 different servers, however middleware only allows one - passenger.

Removed the explicit check for passenger to allow any server call specifies. This will remove a need to make changes to faye-rails next time faye-websocket adds support for a new server.

2) upgraded to latest version of faye (1.1.2) from (1.1.1)

3) fixed ActiveSupport dependency on 'test-unit' which prevented the specs to run

jimsynz commented 9 years ago

Why closed?

cloocher commented 9 years ago

tests are failing in CI althought they run fine on my machine, need to figure out why.