search

jimweirich / gilded_rose_kata

The Gilded Rose Code Cata
206 stars 284 forks source link

Modified tests to remove RSpec warnings #7

Closed chuwik closed 9 years ago

chuwik commented 9 years ago

With RSpec 3.0, the :should syntax has been deprecated in favor of syntax using :expect. Running the tests was giving a warning about this deprecation.

Also, RSpec shows pending tests that pass as failed tests. This can be changed through config modifications, but I think it's easier of all tests pass from the beginning. Changed "pending" to "skip" in the initial 'conjured item' test set, so that they no longer fail because of this.

chuwik commented 9 years ago

I just sadly learnt that Jim passed away in 2014 Rest in peace