search

jimweirich / rake

A make-like build utility for Ruby.
http://rake.rubyforge.org/
1.1k stars 9 forks source link

Support Pathname #271

Closed randycoulman closed 9 years ago

randycoulman commented 10 years ago

These two commits allow client code to use Pathnames when working with Rake. The first commit allows transparent use of Pathnames in FileList, file/directory tasks, and as task prerequisites. The second adds the ext and pathname extension methods to Pathname.

I believe I caught all of the places where Pathnames might be used, but it is possible that I missed something.

The basic philosophy I followed was to convert incoming Pathnames to strings as soon as possible, and allow Rake to work with strings as it always has.

I'd like to find a way to have the ext and pathmap extensions defined automatically if the client code requires 'pathmap'; I didn't want to make Rake require pathmap itself and force it into client code.

drbrain commented 10 years ago

This seems good, I will merge it when preparing rake 10.4

hsbt commented 10 years ago

@randycoulman HI, I merged your pull request on new rake canonical repository.

see. https://github.com/ruby/rake/commit/91af6938586545f46fda26e51d9833c833304788 and https://github.com/ruby/rake/commit/66e495a1fed576b7201520fcd3b9804d53fc93b3