jimweirich / rake

A make-like build utility for Ruby.
http://rake.rubyforge.org/
1.1k stars 9 forks source link

Document argument parsing change in test #279

Closed robbiegill closed 10 years ago

robbiegill commented 10 years ago

There were explicit changes in argument parsing behavior since 10.1.1, but there also seems to be some undocumented changes in handling of some parameters. I actually think the new behavior is more sane, so here's a pr to document the current behavior in tests.

In 10.1.1, 'empty' args were not included in the arg array returned from parse_task_string. In 10.3.2 'empty' args are pass as empty string.

#10.3.2
name, args = @app.parse_task_string("name[one,]") 

name # => 'name'
args # => ['one', '']
#10.1.1
name, args = @app.parse_task_string("name[one,]") 

name # => 'name'
args # => ['one']
hsbt commented 10 years ago

@robbiegill Hi, I merged your pull request on new canonical repository as ruby/rake.

see. https://github.com/ruby/rake/commit/da1c4136748e55fbe99b16130040b5f302db375c

robbiegill commented 10 years ago

Thanks! Closing this pr.